Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to remote algorithm #143

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Fix to remote algorithm #143

merged 1 commit into from
Mar 5, 2025

Conversation

henrikfoss
Copy link
Contributor

@henrikfoss henrikfoss commented Mar 4, 2025

We were giving it a json in, while we wanted to supply a dict.

    def post(self, url, data=None, json=None, **kwargs):
        r"""Sends a POST request. Returns :class:`Response` object.

        :param url: URL for the new :class:`Request` object.
        :param data: (optional) Dictionary, list of tuples, bytes, or file-like
            object to send in the body of the :class:`Request`.
        :param json: (optional) json to send in the body of the :class:`Request`.
        :param \*\*kwargs: Optional arguments that ``request`` takes.
        :rtype: requests.Response
        """

        return self.request("POST", url, data=data, json=json, **kwargs)

@henrikfoss henrikfoss requested a review from a team as a code owner March 4, 2025 16:28
Copy link

github-actions bot commented Mar 4, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
esd_services_api_client/beast/v3
   _connector.py1067925%58–74, 81, 93, 101–120, 140–175, 188–219, 227, 252–255, 262–265, 276–293, 303–309, 318–324
   _models.py1002080%46–50, 107–110, 119–127, 137–145, 153–156
esd_services_api_client/boxer
   _auth.py861780%42–43, 52–61, 70–76, 87
   _connector.py895044%54–58, 64–68, 74–76, 82–84, 92–99, 107–113, 121–128, 136–144, 179, 189–195, 209–218, 228–233
   _models.py27293%49–50
esd_services_api_client/crystal
   _connector.py1195256%55–67, 76, 149, 152, 173–201, 213, 222, 243, 248–259, 278–297, 325, 337–347
esd_services_api_client/nexus/abstractions
   algrorithm_cache.py37370%20–106
   input_object.py14140%20–60
   logger_factory.py16160%20–58
   nexus_object.py34340%20–101
   socket_provider.py15150%20–55
esd_services_api_client/nexus/algorithms
   __init__.py550%20–24
   _baseline_algorithm.py28280%19–88
   _remote_algorithm.py38380%21–114
   distributed.py14140%21–56
   forked_algorithm.py52520%20–176
   minimalistic.py12120%20–47
   recursive.py19190%21–63
esd_services_api_client/nexus/configurations
   algorithm_configuration.py880%4–34
esd_services_api_client/nexus/core
   app_core.py1381380%20–342
   app_dependencies.py1171170%20–320
   serializers.py23230%2–73
esd_services_api_client/nexus/exceptions
   __init__.py110%20
   _nexus_error.py220%21–27
   cache_errors.py13130%20–49
   input_reader_error.py15150%20–51
   startup_error.py22220%4–63
esd_services_api_client/nexus/input
   __init__.py220%21–22
   input_processor.py33330%20–97
   input_reader.py36360%20–105
   payload_reader.py33330%20–83
esd_services_api_client/nexus/modules
   __init__.py550%20–24
   astra_client_module.py14140%20–61
   mlflow_module.py13130%20–43
esd_services_api_client/nexus/telemetry
   recorder.py48480%4–139
   user_telemetry_recorder.py61610%4–170
tests
   test_crystal_connector.py88199%51
TOTAL1612108932% 

Tests Skipped Failures Errors Time
20 0 💤 0 ❌ 0 🔥 15.516s ⏱️

Copy link

github-actions bot commented Mar 4, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
esd_services_api_client/beast/v3
   _connector.py1067925%58–74, 81, 93, 101–120, 140–175, 188–219, 227, 252–255, 262–265, 276–293, 303–309, 318–324
   _models.py1002080%46–50, 107–110, 119–127, 137–145, 153–156
esd_services_api_client/boxer
   _auth.py861780%42–43, 52–61, 70–76, 87
   _connector.py895044%54–58, 64–68, 74–76, 82–84, 92–99, 107–113, 121–128, 136–144, 179, 189–195, 209–218, 228–233
   _models.py27293%49–50
esd_services_api_client/crystal
   _connector.py1185256%55–67, 76, 149, 152, 173–201, 213, 222, 243, 248–259, 278–297, 325, 337–347
esd_services_api_client/nexus/abstractions
   input_object.py14140%20–60
   logger_factory.py16160%20–58
   nexus_object.py34340%20–101
   socket_provider.py15150%20–55
esd_services_api_client/nexus/algorithms
   __init__.py550%20–24
   _baseline_algorithm.py28280%19–88
   _remote_algorithm.py38380%21–114
   distributed.py14140%21–56
   forked_algorithm.py52520%20–176
   minimalistic.py12120%20–47
   recursive.py19190%21–63
esd_services_api_client/nexus/configurations
   algorithm_configuration.py880%4–34
esd_services_api_client/nexus/core
   app_dependencies.py1171170%20–320
   serializers.py23230%2–73
esd_services_api_client/nexus/exceptions
   __init__.py110%20
   _nexus_error.py220%21–27
   cache_errors.py13130%20–49
   input_reader_error.py15150%20–51
   startup_error.py22220%4–63
esd_services_api_client/nexus/input
   __init__.py220%21–22
   input_processor.py33330%20–97
   input_reader.py36360%20–105
   payload_reader.py33330%20–83
esd_services_api_client/nexus/modules
   __init__.py550%20–24
   astra_client_module.py14140%20–61
   mlflow_module.py13130%20–43
esd_services_api_client/nexus/telemetry
   recorder.py48480%4–139
   user_telemetry_recorder.py61610%4–170
tests
   test_crystal_connector.py88199%51
TOTAL143691436% 

Tests Skipped Failures Errors Time
20 0 💤 0 ❌ 0 🔥 15.286s ⏱️

@henrikfoss henrikfoss changed the title Fix to remote Fix to remote algorithm Mar 4, 2025
@henrikfoss
Copy link
Contributor Author

create_package

Copy link

github-actions bot commented Mar 4, 2025

Created package with number v2.5.12a143.dev3

@henrikfoss henrikfoss merged commit 1e1ce3f into main Mar 5, 2025
3 checks passed
@henrikfoss henrikfoss deleted the fix_remote_algorithm branch March 5, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants